using bool in rtl::OUStringBuffer::append

Markus Mohrhard markus.mohrhard at
Wed Oct 3 10:00:54 PDT 2012


>> after I got tinderbox mail complaining about ambiguous overload for
>> rtl::OUStringBuffer::append(bool) I wanted to ask if we could add a
>> rtl::OUStringBuffer::append(bool) method or if there are reasons
>> against it. From what I can see it could in the end even share the
>> implementation with the sal_Bool variant just needs an own method in
>> rtl::OUStringBuffer.
> the overloads of OUStringBuffer::append are pretty horrible already
> (e.g. append(sal_Bool) vs. append(char) or append(sal_Unicode) which is
> always accidentally invoked when you pass a short);  but adding
> append(bool) won't make that any worse than it is.

Seems like append(bool) is not possible without adjusting a lot of
places. The commit seems to have caused some test failures and
crashes. I reverted it for now.


More information about the LibreOffice mailing list