[PUSHED-3-6] fix for fdo#55565 regression
michael.meeks at suse.com
Thu Oct 4 02:20:48 PDT 2012
On Wed, 2012-10-03 at 10:15 +0100, Noel Power wrote:
> please consider this patch
Pushed; IIRC using:
- if ( aProps[ i ].Name.equals( "TextPreRotateAngle" ) ..
+ if ( aProps[ i ].Name == "TextPreRotateAngle" ...
Is more efficient (by the power of Lubos' cunning), avoiding a dynamic
allocation, and a couple of atomic operations each comparison. Though
perhaps I remember wrong.
If that's right, would it make sense to have an easy-hack to go over
all re-based modules hunting and replacing .equals with == ?
$ git grep 'equals(' | grep \.cxx | less
Or am I loosing it ;-)
michael.meeks at suse.com <><, Pseudo Engineer, itinerant idiot
More information about the LibreOffice