[PUSHED] Re: [PATCH] sal_Bool -> bool in various places
michael.meeks at suse.com
Fri Oct 5 02:12:56 PDT 2012
On Thu, 2012-10-04 at 21:36 +0200, Michael Stahl wrote:
> > Patch 20 might need some careful scrutiny since it adds extra operators
> > to SvStream for handling bool.
> that sounds like a horrible idea to me: the use of overloading for
> binary serialization of integers is a recipe for disaster in the first
> place, because the serialization format can be changed accidentally then
> by changing the type of some variable, or worse, some typedef or return
> type of a function that happens to be used for serialization.
> please add a WriteBool() method or something like that, and hopefully
> the compiler will point you to the places where it has to be used.
Completely agreed; IIRC we had an easy-hack to convert all of those
operators to using WriteFoo methods instead systematically. That would
be a deadly useful task (post re-base). Hopefully - with some clang
skills we could (potentially) do some automated code re-writing there
michael.meeks at suse.com <><, Pseudo Engineer, itinerant idiot
More information about the LibreOffice