[PATCH] cppcheck : redundantCondition. In this case, it seems to be ...

Christophe JAILLET (via Code Review) gerrit at gerrit.libreoffice.org
Sat Oct 6 09:07:52 PDT 2012


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/779

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/779/1

cppcheck : redundantCondition. In this case, it seems to be a typo.

Changed the redundant check against fRate with a test against fPrice as
everywhere else in the file.
Also change some comparisons against 0.0 instead of 0 when using floating
point variable (to be consistent with the rest of the code).

Change-Id: I94a397f1578a90156359987996cb1ef02d5e4209
---
M scaddins/source/analysis/financial.cxx
1 file changed, 7 insertions(+), 7 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/779
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I94a397f1578a90156359987996cb1ef02d5e4209
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Christophe JAILLET <christophe.jaillet at wanadoo.fr>



More information about the LibreOffice mailing list