need help with unit test and process service factory

[Eike Rathke]

Hi Michael,

On Wednesday, 2012-10-10 20:59:54 +0100, Michael Meeks wrote:

> > Do you mean g_main_context_iteration ?
> > It's used both in the real code and unit test.
> 
> 	It shouldn't be used in the real code - we should integrate with the
> glib mainloop that is plugged into VCL :-)

AFAIK we do that for real code (if things didn't change).

> > From what I understood, it's how telepathy framework works and it
> > can't be avoided.

> 	The problem is a careless use of an iteration; if we ran the mainloop
> until an asynchronous callback quit it - that would be -much- less of a
> problem :-)

And we do that :-)

> The root problem is trying to 2nd guess how many main-loop
> iterations to call - which is non documented, non deterministic and
> guarenteed to change between minor releases :-)

And we don't do it ;-)

    while (!pImpl->mbAccountManagerReadyHandlerInvoked)
            g_main_context_iteration( NULL, TRUE);

spins the main loop until the callback set
mbAccountManagerReadyHandlerInvoked=true

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20121011/c01eca52/attachment.pgp>