settings.mk : subst construct

David Tardon dtardon at redhat.com
Sun Oct 14 22:08:45 PDT 2012


Hi,

On Sun, Oct 14, 2012 at 11:31:15PM +0200, Mat M wrote:
> Le Sat, 13 Oct 2012 04:51:26 +0200, Norbert Thiebaud
> <nthiebaud at gmail.com> a écrit:
> 
> >On Fri, Oct 12, 2012 at 6:45 PM, Mat M <matm at gmx.fr> wrote:
> >>Is the construct legal or is there an issue here ?
> >>If it is legal, I'd love to have an explanation, because I had no great
> >>success when googling.
> >
> >http://www.openoffice.org/tools/dmake/dmake_4.3.html
> 
> Oh,  I assumed it was GNU make stuff.
> 
> >$(subst,pat,replacement data)
> >    Will search for pat in data and will replace any occurrence of pat
> >with the replacement string. The expansion
> >
> >        $(subst,.o,.c $(OBJECTS))
> >
> >    is equivalent to:
> >
> >        $(OBJECTS:s/.o/.c/)
> 
> Syntax is different from gmake, so...
> 
> Thank you Norbert
> 
> So, now I took back the code from settings.mk around line 554
> COMMON_OUTDIR:=$(OUTPATH)
> 
> LOCAL_OUT:=$(OUT)
> LOCAL_OUT_FOR_BUILD:=$(OUT_FOR_BUILD)
> LOCAL_COMMON_OUT:=$(subst,$(OUTPATH),$(COMMON_OUTDIR) $(OUT))
> .EXPORT : LOCAL_OUT LOCAL_COMMON_OUT
> 
> here LOCAL_COMMON_OUT:=$(OUT) is enough or am I missing another thing ?

No, you are right. But I would not spend any time looking for possible
improvements in solenv/inc . The old build system based on dmake is
scheduled to die.

D.


More information about the LibreOffice mailing list