[REVIEW 3-6-3 2/3][PUSHED 3-6] fix for fdo#55885, don't insert notes to deleted cells

Noel Power nopower at novell.com
Mon Oct 15 12:58:42 PDT 2012


On 15/10/12 14:15, Eike Rathke wrote:
> Hi,
>
> On Saturday, 2012-10-13 13:38:07 -0400, Kohei Yoshida wrote:
>
>> On Sat, Oct 13, 2012 at 1:22 AM, Markus Mohrhard
>> <markus.mohrhard at googlemail.com>  wrote:
>>
>>> Yeap, my mistake. It misses the -nStartRow or -nStartCol that makes
>>> the nRow/nCol relative to the deleted column/row.
>>>
>>> I attached a patch that squashs both necessary commits into one.
>> Yup. That looks more like it. Pushed it to 3-6 with my sign-off.
>> We'll need to work on adding a test case for this later (on master)...
>>
>> Two more sign-off's needed to push this change to 3-6-3.
> Here's mine, one more needed.
>
here's one more, I've struggled for hours to get a connection here, no 
chance I can push it so if someone can do the honours that would be great

Noel


More information about the LibreOffice mailing list