[PATCH] warn free build of dmake, concat-deps and lpsolve

René Kjellerup (via_Code_Review) gerrit at gerrit.libreoffice.org
Fri Oct 19 11:23:02 PDT 2012


I have submitted a patch for review:


To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/891/1

warn free build of dmake, concat-deps and lpsolve

I've added if test to silence compiler warnings like this:
"warning: ignoring return value of 'fwrite', declared with attribute warn_unused_result"
to make the compiler think we care about the return value of those function calls.
they work like this:
if( function_call(...) ) ;
meaning if true do a nop false just continue on your marry way.

Also in lpsolve moved from  "fprintf(output, (char* variable))" to "fputs((char* variable), output)"
because of a compiler warning that it couldn't varify the format string because it wasn't a
string literal.

Change-Id: Ib00b3e93b46bef12dc9019761508a76ceb84319a
M dmake/unix/arlib.c
A lpsolve/lp_solve-fixed-warn.patch
M lpsolve/lp_solve_5.5.patch
M lpsolve/makefile.mk
M solenv/bin/concat-deps.c
5 files changed, 79 insertions(+), 14 deletions(-)

To view, visit https://gerrit.libreoffice.org/891
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib00b3e93b46bef12dc9019761508a76ceb84319a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: René Kjellerup <rk.katana.steel at gmail.com>

More information about the LibreOffice mailing list