[PATCH] warn free build of dmake, concat-deps and lpsolve

René Kjellerup (via_Code_Review) gerrit at gerrit.libreoffice.org
Mon Oct 22 15:29:30 PDT 2012


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/898

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/898/1

warn free build of dmake, concat-deps and lpsolve

I've added if test to silence compiler warnings like this:
"warning: ignoring return value of 'fwrite', declared with attribute warn_unused_result"
to make the compiler think we care about the return value of those function calls.
they work like this:
if( function_call(...) ) ;
meaning if true do a nop false just continue on your marry way.

Also in lpsolve moved from "fprintf(output, (char* variable))" to "fputs((char* variable), output)"
because of a compiler warning that it couldn't varify the format string because it wasn't a
string literal.

Change-Id: I72dae83b47c2021cea7c339d5f397a82ee043346
---
M lpsolve/lp_solve-fixed-warn.patch
1 file changed, 11 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/898
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I72dae83b47c2021cea7c339d5f397a82ee043346
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: René Kjellerup <rk.katana.steel at gmail.com>



More information about the LibreOffice mailing list