[PATCH] Bug 51309 - Names of DatabaseRanges should not be case sensitive

Markus Mohrhard markus.mohrhard at googlemail.com
Mon Oct 29 16:22:14 PDT 2012

Hey Mathieu,

2012/10/26 Mathieu D. <call.protected at gmail.com>:
> Hi,
> I submitted a patch for the bug 51309 - Names of DatabaseRanges should not
> be case sensitive :
> https://bugs.freedesktop.org/show_bug.cgi?id=51309
> You will the diff file attached and on the bug's page.
> https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=51309&attachment=69115
> Changes :
> - ScDBData::less::operator() is modified to compare upper strings
> - All the calls to NamedDBs::findByName() are now
> NamedDBs::findByUpperName().
> - In case of a call to findByUpperName by an argument, the function
> ScGlobal::pCharClass->uppercase(aName) was used to ensure upper case.
> - The definitions of FindByName() are deleted.

The patch looks good. Could you please create the patch with git
commit -a && git format-patch HEAD~1 so that it includes you correctly
as author.

And please could you send a licence statement like:

All of my past and future contributions to LibreOffice may be licensed
under the MPL/LGPLv3+
dual license.

to the Mailing so list so that we can keep track of it at

Thanks a lot for your great contribution. Are there any areas that
interest you? Are you interested in more calc hacking?


More information about the LibreOffice mailing list