[REVIEW 3-6] fdo#56325 - Every simple fix for pivot table's database query bug

Kohei Yoshida kohei.yoshida at gmail.com
Tue Oct 30 18:01:01 PDT 2012


Hi there,

I'd like to have the attached patch pushed to the 3-6 branch in order to fix

https://bugs.freedesktop.org/show_bug.cgi?id=56325

This patch is basically an equivalent of

http://cgit.freedesktop.org/libreoffice/core/commit/?id=acfdd93f31ae59bb688c27d2fd57e1940a6b9370

on master, but due to my earlier indentation fix, it won't simply be
cherry-picked to the 3-6 branch. But the two changes are basically the same
change minus the indentation difference.

The punch line of this fix is that I just forgot to build the tree of
flat_segment_tree before it was searched in isRowActive().  That ended up
filtering out all the records incorrectly for the database data source,
which would end up with an empty table output.

Kohei
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20121030/046631a0/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fdo-56325-Don-t-forget-to-build_tree-in-fillTable.patch
Type: application/octet-stream
Size: 1664 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20121030/046631a0/attachment-0001.obj>


More information about the LibreOffice mailing list