[PUSHED] Fix for docking property browser

Gerrit gerrit at gerrit.libreoffice.org
Fri Sep 7 02:14:13 PDT 2012


>From Noel Power <noel.power at suse.com>:

Noel Power has submitted this change and it was merged.

Change subject: Fix for docking property browser
......................................................................


Fix for docking property browser

This fixes the crash of 'Basic IDE: Docking property browser under
object catalog' commit. The aPropertyBrowser data member was replaced by
a new-allocated pointer. We need this because toolkit releases it by
delete.
When the property browser is closed in the floating state, it tells
DialogWindowLayout to null the pointer. If the user clicks the 'property
browser' button on the toolbar, it is created again.

Change-Id: Ie842a72fe37dfdd2ed5921ffa2f1f41d3f2c51c6
---
M basctl/source/basicide/baside3.cxx
M basctl/source/basicide/layout.cxx
M basctl/source/basicide/layout.hxx
M basctl/source/dlged/dlged.cxx
M basctl/source/dlged/propbrw.cxx
M basctl/source/inc/baside3.hxx
M basctl/source/inc/dlged.hxx
M basctl/source/inc/propbrw.hxx
8 files changed, 144 insertions(+), 28 deletions(-)

Approvals:
  Noel Power: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/568
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie842a72fe37dfdd2ed5921ffa2f1f41d3f2c51c6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: János Uray <uray.janos at gmail.com>
Gerrit-Reviewer: János Uray <uray.janos at gmail.com>
Gerrit-Reviewer: Noel Power <noel.power at suse.com>



More information about the LibreOffice mailing list