Need help fixing fdo#38557

Muthu Subramanian K sumuthu at suse.com
Wed Sep 12 00:38:21 PDT 2012


Hi Niklas,

We may have to do something like:
http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/drtxtob1.cxx#254
Maybe header/footer views aren't invalidated when we click 'OK'? I am 
just guessing.

PS: I am not too familiar with this part of the code, unfortunately :(

Thanks & Regards,
Muthu Subramanian

On 09/07/2012 09:39 PM, Niklas Johansson wrote:
> Hi
>
> No worries, it was my bad for failing to mention Impress in my original
> message. ;)
>
> I've been stepping through the code a lot of times and well it seems to
> go over my head.
>
> I found something interesting in the ViewShells [1] in the method
> UpdatePreview which is called from drviews3.cxx. The method only
> contains this comment.
> // Do nothing.  After the actual preview has been removed,
> // OutlineViewShell::UpdatePreview() is the place where something
> // usefull is still done.
>
> The method above would update the preview pages to the left I think so
> not exactly what I was aiming for. :(
>
> [1]
> http://opengrok.libreoffice.org/xref/core/sd/source/ui/inc/ViewShell.hxx#223
>
>
> Regards,
> Niklas Johansson
>
> Cedric Bosdonnat skrev 2012-09-07 11:26:
>> Hi Niklas,
>>
>> Please excuse Michael as he redirected you to the wrong guy... this is
>> an Impress problem, better see with the Impress hackers ;) Thorsten,
>> Muthu, Radek could you help him?
>>
>> --
>> Cedric
>>
>> On Thu, 2012-09-06 at 17:22 +0100, Michael Meeks wrote:
>>> Hi Niklas,
>>>
>>>     Sadly I'm no writer expert :-) did you get any further ? if not
>>> Cedric
>>> is one person with a good overview there I suspect; Cedric ?
>>>
>>>     ATB,
>>>
>>>         Michael.
>>>
>>> On Fri, 2012-08-31 at 17:40 +0200, Niklas Johansson wrote:
>>>> I'm currently looking at fdo#38557 [1] and could use some pointers.
>>>> Summary of the bug: After using the Header and footer dialog (View
>>>> menu)
>>>> changes does not get displayed until you add a new page (or something
>>>> else that triggers an update of the page layout).
>>>>
>>>> I tracked down the dialog to headerfooterdlg.cxx [2] the
>>>> HeaderFooterDialog:apply is called from ApplyToAll or Apply
>>>> depending on
>>>> witch button you press.
>>>>
>>>> In HeaderFooterDialog::apply the properties from the dialog is set but
>>>> it does not update the view on screen.
>>>>
>>>> Where is such an update supposed to happen? In the execute function? Is
>>>> it even supposed to be handled in headerfooterdlg.cxx or do I have
>>>> to go
>>>> deeper?
>>>>
>>>>
>>>> [1] https://bugs.freedesktop.org/show_bug.cgi?id=38557
>>>> [2]
>>>> http://opengrok.libreoffice.org/xref/core/sd/source/ui/dlg/headerfooterdlg.cxx#304
>>>>
>>>>
>>
>
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>



More information about the LibreOffice mailing list