cppcheck duplicateExpression in filter/source/graphicfilter/icgm/actimpr.cxx

[julien2412]

Hello,

Cppcheck reported this:
[filter/source/graphicfilter/icgm/actimpr.cxx:340] ->
[filter/source/graphicfilter/icgm/actimpr.cxx:338]: (style) Found duplicate
branches for if and else

Here are the lines:
    338         if ( mpCGM->pElement->nAspectSourceFlags & ASF_LINECOLOR )
    339             aHatch.Color = nFillColor;
    340         else
    341             aHatch.Color = nFillColor;

Can I just remove the if else and keep "aHatch.Color = nFillColor;" since
it's like that from the first commit of this file in 2009?

Julien



--
View this message in context: http://nabble.documentfoundation.org/cppcheck-duplicateExpression-in-filter-source-graphicfilter-icgm-actimpr-cxx-tp4007770.html
Sent from the Dev mailing list archive at Nabble.com.