[libreoffice-commits] Hopefully this is the last of the cleanups for class ScDocument for now.
Stephan Bergmann
sbergman at redhat.com
Mon Sep 17 00:39:26 PDT 2012
On 09/13/2012 12:40 PM, Stephan Bergmann wrote:
> causes a warning now that fValue is uninitialized in the assignment
>
> fPrevValue = fValue;
>
> (in code below the code shown above). From bPrevString, bPrevEmpy,
> bString, and bEmpty always being true, it looks like fPrevValue and
> fValue have become unused anyway, but it looks a little suspicious to me
> that this code has degraded now to a glorious way of repeatedly calling
> WriteCell to only ever write empty cells. I know too little about this
> area to tell whether this is as intended or got broken. (And the
> respective code in sc/source/filter/xml/XMLExportDDELinks.cxx has
> diverted sufficiently by now to prevent direct comparison.)
Anyway, fixed the warning for now by reducing the code even further,
keeping the current functionality as-is;
<http://cgit.freedesktop.org/libreoffice/binfilter/commit/?id=c825a7be7e5920519b485e7a133e97c1e9d93849>
"-Werror,-Wuninitialized."
Stephan
More information about the LibreOffice
mailing list