sal/config.g sal/types.h and sal/osl/rtl includes in general

d.ostrovsky at idaia.de d.ostrovsky at idaia.de
Wed Sep 19 06:27:44 PDT 2012


Quoting Stephan Bergmann <sbergman at redhat.com>:

>> On 09/18/2012 12:14 AM, Norbert Thiebaud wrote:
>> [...]
>> for 2/
>> I propose to create a file 'lo.h', in solenv/inc/ for now... and start
>> to bring all source code in conformance... [...]
>
> I'm not sure such a lo.h combining inclusion of multiple other  
> header files would be a good idea.  With the constant flux across  
> our code base, I think aiming at precise, minimal includes is a  
> better approach, as it helps achieving minimal rebuilds.
+1 for that.
Was spending hours (!) yesterday during rebuilds with total ccache  
misses because of recent header changes.

In generall to make the life of (casual) contributor as easy as  
possible is the highest priority in open source
environment. Not everybody posses the up to date hardware and/or time.  
Of topic but in the same context - "achieving minimal rebuilds" -  
still urgently missing these build options:

--disable-all-tests (or new build target make  
dev-instal-without-unit-tests for that matter)
yes i know you don't want it, and that project is not a debate club,  
and someone must decide and you did.
Well I accept your decision ... and disagree.

--disable-cve-tests
CVE unit tests still prevent me from be able to compile LO on windows  
with activated antivirus. Someone wanted implement it? Who was it? Mat  
M. or me? ;-) Note: once we have --disable-all-tests we probably don't  
need it.

--enable-apps-only="base sw"
if someone is working on one or two apps there is no reason to rebuild  
the whole suite all the time.

Ciao
David


More information about the LibreOffice mailing list