[REVIEW 3-6] For msi installer, only default-select a subset of dictionaries

Stephan Bergmann sbergman at redhat.com
Fri Sep 21 06:12:09 PDT 2012


This is about backporting to libreoffice-3-6 the fix for part 1 of 
<https://bugs.freedesktop.org/show_bug.cgi?id=53009> "Large 
UserInstallation's user/extensions/bundled/ tree," namely 
default-selecting only a reasonable subset of the 40+ dictionaries that 
come included with LO's msi installer (see 
<https://bugs.freedesktop.org/show_bug.cgi?id=53009#c10>).

I'm switching back to the good old way of using the ML rather than 
gerrit to propose this backport, for various reasons:

* The fix spans multiple commits, for multiple issues and multiple 
repositories.  0001-Fix-for-fdo-53520-Portuguese-spelling-files.patch is 
for the dictionaries repo, the other 0001...0006 are for the core repo.

* There was a naming inconsistency for the pt-BR and pt-PT dictionaries 
that caused the data in 
setup_native/source/packinfo/spellchecker_selection.txt (which is used 
in the fix) to not match reality, and 
<https://bugs.freedesktop.org/show_bug.cgi?id=53520> "[PACKAGING] 
Brazilian spell-check pt-BR named as pt-PT" fixes that, so the easiest 
(though somewhat further-reaching) solution is to backport that fix as 
well.  (Hence the many commits split across two repos.)

* The benefit of this fix for somebody doing an upgrade from a previous 
LO installation is not evident:  As LO's msi installer keeps selected 
those features that were selected for the previous installation, this 
fix's pruning of the list of default-selected dictionaries would not 
kick in, and instead the default-selected list would cover exactly those 
dictionaries that were already installed before (which typically is 
all).  It only effectively affects brand-new installations.

Stephan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fdo-53520-rename-portuguese-dicts.patch
Type: text/x-patch
Size: 3495 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120921/8bbde532/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-fix-bug-fdo-53520-pt-PT-and-pt-BR-better-split.patch
Type: text/x-patch
Size: 3783 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120921/8bbde532/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-fdo-53520-Adapt-to-dict-pt-.oxt-renames-and-more-pt-.patch
Type: text/x-patch
Size: 1581 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120921/8bbde532/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-fdo-53520-One-more-dict-pt-vs.-pt-PT-inconsitency.patch
Type: text/x-patch
Size: 928 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120921/8bbde532/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Some-code-simplification.patch
Type: text/x-patch
Size: 4642 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120921/8bbde532/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-fdo-53009-For-msi-installer-only-default-select-a-su.patch
Type: text/x-patch
Size: 9870 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120921/8bbde532/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-for-fdo-53520-Portuguese-spelling-files.patch
Type: text/x-patch
Size: 1867 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120921/8bbde532/attachment-0013.bin>


More information about the LibreOffice mailing list