using bool in rtl::OUStringBuffer::append

Michael Stahl mstahl at redhat.com
Mon Sep 24 06:15:28 PDT 2012


On 23/09/12 22:49, Markus Mohrhard wrote:
> Hey,
> 
> after I got tinderbox mail complaining about ambiguous overload for
> rtl::OUStringBuffer::append(bool) I wanted to ask if we could add a
> rtl::OUStringBuffer::append(bool) method or if there are reasons
> against it. From what I can see it could in the end even share the
> implementation with the sal_Bool variant just needs an own method in
> rtl::OUStringBuffer.

the overloads of OUStringBuffer::append are pretty horrible already
(e.g. append(sal_Bool) vs. append(char) or append(sal_Unicode) which is
always accidentally invoked when you pass a short);  but adding
append(bool) won't make that any worse than it is.




More information about the LibreOffice mailing list