[PATCH] API CHANGE: drop rtl::O[U]StringBuffer::{charAt,setCharAt}

[Thomas Arnhold (via Code Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3155

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/3155/1

API CHANGE: drop rtl::O[U]StringBuffer::{charAt,setCharAt}

As a follow up of fdo#41474. See:

https://wiki.documentfoundation.org/Development/LibreOffice4

Change-Id: Ief3a418e2ab0039bdf5100ec6e1505a4887487e7
---
M sal/inc/rtl/strbuf.hxx
M sal/inc/rtl/ustrbuf.hxx
2 files changed, 0 insertions(+), 76 deletions(-)



diff --git a/sal/inc/rtl/strbuf.hxx b/sal/inc/rtl/strbuf.hxx
index 4dabc76..be8b0b1 100644
--- a/sal/inc/rtl/strbuf.hxx
+++ b/sal/inc/rtl/strbuf.hxx
@@ -366,44 +366,6 @@
     }
 
     /**
-        Returns the character at a specific index in this string buffer.
-
-        The first character of a string buffer is at index
-        <code>0</code>, the next at index <code>1</code>, and so on, for
-        array indexing.
-        <p>
-        The index argument must be greater than or equal to
-        <code>0</code>, and less than the length of this string buffer.
-
-        @param      index   the index of the desired character.
-        @return     the character at the specified index of this string buffer.
-    */
-    SAL_DEPRECATED("use rtl::OStringBuffer::operator [] instead")
-    sal_Char charAt( sal_Int32 index )
-    {
-        assert(index >= 0 && index < pData->length);
-        return pData->buffer[ index ];
-    }
-
-    /**
-        The character at the specified index of this string buffer is set
-        to <code>ch</code>.
-
-        The index argument must be greater than or equal to
-        <code>0</code>, and less than the length of this string buffer.
-
-        @param      index   the index of the character to modify.
-        @param      ch      the new character.
-     */
-    SAL_DEPRECATED("use rtl::OStringBuffer::operator [] instead")
-    OStringBuffer & setCharAt(sal_Int32 index, sal_Char ch)
-    {
-        assert(index >= 0 && index < pData->length);
-        pData->buffer[ index ] = ch;
-        return *this;
-    }
-
-    /**
         Return a null terminated character array.
      */
     const sal_Char* getStr() const { return pData->buffer; }
diff --git a/sal/inc/rtl/ustrbuf.hxx b/sal/inc/rtl/ustrbuf.hxx
index 95993fc..b5a1db5 100644
--- a/sal/inc/rtl/ustrbuf.hxx
+++ b/sal/inc/rtl/ustrbuf.hxx
@@ -358,44 +358,6 @@
     }
 
     /**
-        Returns the character at a specific index in this string buffer.
-
-        The first character of a string buffer is at index
-        <code>0</code>, the next at index <code>1</code>, and so on, for
-        array indexing.
-        <p>
-        The index argument must be greater than or equal to
-        <code>0</code>, and less than the length of this string buffer.
-
-        @param      index   the index of the desired character.
-        @return     the character at the specified index of this string buffer.
-     */
-    SAL_DEPRECATED("use rtl::OUStringBuffer::operator [] instead")
-    sal_Unicode charAt( sal_Int32 index ) const
-    {
-        assert(index >= 0 && index < pData->length);
-        return pData->buffer[ index ];
-    }
-
-    /**
-        The character at the specified index of this string buffer is set
-        to <code>ch</code>.
-
-        The index argument must be greater than or equal to
-        <code>0</code>, and less than the length of this string buffer.
-
-        @param      index   the index of the character to modify.
-        @param      ch      the new character.
-     */
-    SAL_DEPRECATED("use rtl::OUStringBuffer::operator [] instead")
-    OUStringBuffer & setCharAt(sal_Int32 index, sal_Unicode ch)
-    {
-        assert(index >= 0 && index < pData->length);
-        pData->buffer[ index ] = ch;
-        return *this;
-    }
-
-    /**
         Return a null terminated unicode character array.
      */
     const sal_Unicode*  getStr() const { return pData->buffer; }

-- 
To view, visit https://gerrit.libreoffice.org/3155
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief3a418e2ab0039bdf5100ec6e1505a4887487e7
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Thomas Arnhold <thomas at arnhold.org>