reduce some uglyness

Michael Stahl mstahl at redhat.com
Tue Apr 2 02:51:27 PDT 2013


On 30/03/13 14:59, Thomas Arnhold wrote:
> Hi,
> 
> two weeks ago I did some rearranging of rngitem, but the build broke on 
> the windows tinderbox Win-x86_6 (revert: 
> df8c41cceeca27ae49e9fa6b5cd64c65c8feb218).
> 
> This was the error message:
> 
> error C2011: ´SfxRangeItem´ : ´class´ type redefinition
> error C2011: ´SfxUShortRangesItem´ : ´class´ type redefinition
> ....
> 
> Strangely all other tinderboxes were happy about the commit. Was this 
> error introduced due to the incremental build on that machine? If so I 
> will resubmit the patch.

it's a mystery why it works on other compilers, because you have removed
the header guard "#define _SFXRNGITEM_HXX" which causes multiple
inclusion of the header to define the same types multiple times, which
MSVC rightfully complains about.

i grant that the header guard in rngitem.hxx is really bizarre though.



More information about the LibreOffice mailing list