[Libreoffice-commits] core.git: use LanguageTag instead of comphelper::Locale

Eike Rathke erack at redhat.com
Tue Apr 2 10:27:53 PDT 2013


Hi Stephan,

On Thursday, 2013-03-28 18:28:30 +0100, Stephan Bergmann wrote:

> >--- a/configmgr/source/configurationprovider.cxx
> >+++ b/configmgr/source/configurationprovider.cxx
> >@@ -337,20 +339,10 @@ void Service::setLocale(css::lang::Locale const & eLocale)
> >-    if ( locale_ == "*" ) {
> >+    if ( locale_ == "*" ) {     /* FIXME-BCP47: WTF is this?!? */
> 
> A configuration provider can operate in one of two modes with
> regards to localized properties.  It can either be set up to use a
> specific locale, and return the best matching localized value for a
> given localized property.  Or it can be set up (via "*") to treat
> localized properties like sets, where each individual localized
> value is accessible under the locale's name.

Oh my ... seeing
offapi/com/sun/star/configuration/AdministrationProvider.idl and
offapi/com/sun/star/configuration/*Access.idl we even exposed "*" to the
outer world and should regard it as "ugly nasty wrong but stable API"
... and comphelper/source/misc/configuration.cxx and
comphelper/source/misc/configurationhelper.cxx use it ... the torture
never stops..

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
For key transition see http://erack.de/key-transition-2013-01-10.txt.asc
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130402/38c0c82d/attachment.pgp>


More information about the LibreOffice mailing list