[PATCH] fdo#42781 Do not unnecessarily ignore MSVC warnings

Petr Kraus (via Code Review) gerrit at gerrit.libreoffice.org
Thu Apr 4 08:39:09 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3203

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/3203/1

fdo#42781 Do not unnecessarily ignore MSVC warnings

Removed some ignored warnings for MSVC compiler
that should not occur. MSVC 2010 can, but do not issue these for me.
Some of them are "disabled by default" and should not occur unless -Wall
C warnings: C4250, C4255, C4275, C4290, C4503, C4511, C4611, C4640
CXX warnings: C4242, C4265, C4503, C4511, C4626, C4640

Change-Id: I61b692a9c02a8900f80b019e11ad4acdea3e4dfc
---
M solenv/gbuild/platform/com_MSC_defs.mk
1 file changed, 0 insertions(+), 27 deletions(-)



diff --git a/solenv/gbuild/platform/com_MSC_defs.mk b/solenv/gbuild/platform/com_MSC_defs.mk
index e8488ef..9675e2d 100644
--- a/solenv/gbuild/platform/com_MSC_defs.mk
+++ b/solenv/gbuild/platform/com_MSC_defs.mk
@@ -98,12 +98,6 @@
 # C4251: 'identifier' : class 'type' needs to have dll-interface to be
 #   used by clients of class 'type2'
 
-# C4255: 'function' : no function prototype given: converting '()' to
-#   '(void)'
-
-# C4265: 'class' : class has virtual functions, but destructor is not
-#   virtual
-
 # C4275: non-DLL-interface classkey 'identifier' used as base for
 #   DLL-interface classkey 'identifier'
 
@@ -119,12 +113,7 @@
 #   of the compiler did not override when parameters only differed by
 #   const/volatile qualifiers.
 
-# C4503: 'identifier' : decorated name length exceeded, name was
-#   truncated
-
 # C4505: 'function' : unreferenced local function has been removed
-
-# C4511: 'class' : copy constructor could not be generated
 
 # C4512: 'class' : assignment operator could not be generated
 
@@ -133,8 +122,6 @@
 
 # C4626: 'derived class' : assignment operator could not be generated
 #   because a base class assignment operator is inaccessible
-
-# C4640: 'instance' : construction of local static object is not thread-safe
 
 # C4706: assignment within conditional expression
 
@@ -157,19 +144,11 @@
 	-wd4242 \
 	-wd4244 \
 	-wd4245 \
-	-wd4250 \
 	-wd4251 \
-	-wd4255 \
-	-wd4275 \
-	-wd4290 \
 	-wd4355 \
-	-wd4503 \
 	-wd4505 \
-	-wd4511 \
 	-wd4512 \
-	-wd4611 \
 	-wd4626 \
-	-wd4640 \
 	-wd4706 \
 	-wd4800 \
 	-Zc:forScope,wchar_t- \
@@ -187,24 +166,18 @@
 	-wd4127 \
 	-wd4180 \
 	-wd4189 \
-	-wd4242 \
 	-wd4244 \
 	-wd4245 \
 	-wd4250 \
 	-wd4251 \
-	-wd4265 \
 	-wd4275 \
 	-wd4290 \
 	-wd4351 \
 	-wd4355 \
 	-wd4373 \
-	-wd4503 \
 	-wd4505 \
-	-wd4511 \
 	-wd4512 \
 	-wd4611 \
-	-wd4626 \
-	-wd4640 \
 	-wd4706 \
 	-wd4800 \
 	-wd4996 \

-- 
To view, visit https://gerrit.libreoffice.org/3203
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61b692a9c02a8900f80b019e11ad4acdea3e4dfc
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Petr Kraus <petr_kraus at email.cz>



More information about the LibreOffice mailing list