[PATCH libreoffice-4-0] fdo#62155 - band-aid crash from poor addin registration on u...

[Michael Meeks (via Code Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3212

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/3212/1

fdo#62155 - band-aid crash from poor addin registration on upgrade

For some sadly unknown reason we get an exception traversing the
calc addins and crashing doesn't seem a great response to that.

Change-Id: I8d1eda7c8bab384817f19a86607c7035e4c3a8ab
---
M sc/source/core/tool/addincol.cxx
1 file changed, 3 insertions(+), 0 deletions(-)



diff --git a/sc/source/core/tool/addincol.cxx b/sc/source/core/tool/addincol.cxx
index 8f63781..6c92d4c 100644
--- a/sc/source/core/tool/addincol.cxx
+++ b/sc/source/core/tool/addincol.cxx
@@ -291,6 +291,7 @@
             {
                 uno::Any aAddInAny = xEnum->nextElement();
 
+                try
                 {
                     uno::Reference<uno::XInterface> xIntFac;
                     aAddInAny >>= xIntFac;
@@ -321,6 +322,8 @@
                             }
                         }
                     }
+                } catch ( const uno::Exception& ) {
+                    SAL_WARN ( "sc", "Failed to initialize create instance of sheet.AddIn" );
                 }
             }
         }

-- 
To view, visit https://gerrit.libreoffice.org/3212
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d1eda7c8bab384817f19a86607c7035e4c3a8ab
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Michael Meeks <michael.meeks at suse.com>