[Libreoffice-commits] core.git: fix fdo#60534 : use DefaultCharMapper::mapChar() to map RTL string unicodes

Stephan Bergmann sbergman at redhat.com
Mon Apr 8 08:36:54 PDT 2013


On 04/08/2013 05:15 PM, Stephan Bergmann wrote:
> The below breaks on MSVC/Windows, against our internal icu 51.  Its
> DefaultCharMapper (icu/source/layout/DefaultCharMapper.h) and
> LECharMapper (icu/source/layout/LEFontInstance.h) it is derived from are
> not marked as U_LAYOUT_API, so their non-inline function definitions
> (esp., LECharMapper::~LECharMapper and DefaultMapper::mapChar) are not
> exported on Windows.  They are virtual, so this wouldn't be a problem if
> DefaultCharMapper were used in a way that function calls would
> necessarily be resolved via vtable, but that's not the case in the below
> code.

addressed for now with 
<http://cgit.freedesktop.org/libreoffice/core/commit/?id=21fea27309a75b86add08918d2a2a2234ae1f1fb> 
"Make icu's DefaultCharMapper usable on Windows."

Stephan



More information about the LibreOffice mailing list