[PATCH libreoffice-4-0] Resolves: fdo#61948 delayed delete deletes nothing under win...

[Caolán McNamara (via_Code_Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3288

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/3288/1

Resolves: fdo#61948 delayed delete deletes nothing under windows

The reason there appears to be two dialogs, is because there
actually is. The original dialog doesn't get deleted under
windows.

If we use the actual returned type of the dialog here rather than a lower
baseclass then the right thing happens. Original code works under Linux but not
Windows.

Change-Id: Iaf99fa4e16f743b1f5a3d29f42a140491f3d67b0
(cherry picked from commit afb3af7ce5fef803d42a549095863e6bb8210ef2)
---
M sc/source/ui/view/cellsh2.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/sc/source/ui/view/cellsh2.cxx b/sc/source/ui/view/cellsh2.cxx
index 1ab57f6..0e4a720 100644
--- a/sc/source/ui/view/cellsh2.cxx
+++ b/sc/source/ui/view/cellsh2.cxx
@@ -178,7 +178,7 @@
 {
     long DelayDeleteAbstractDialog( void *pAbstractDialog, void * /*pArg*/ )
     {
-        delete reinterpret_cast<VclAbstractDialog*>( pAbstractDialog );
+        delete reinterpret_cast<SfxAbstractTabDialog*>( pAbstractDialog );
         return 0;
     }
 }

-- 
To view, visit https://gerrit.libreoffice.org/3288
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf99fa4e16f743b1f5a3d29f42a140491f3d67b0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Caolán McNamara <caolanm at redhat.com>