[PUSHED] fdo#62096: [cleanup] Replaced some compareTo with '=='

Miklos Vajna vmiklos at suse.cz
Wed Apr 10 01:10:20 PDT 2013


Hi Prashant,

On Wed, Apr 10, 2013 at 06:04:50AM +0530, Prashant Pandey <prashant3.yishu at gmail.com> wrote:
> I've attached a patch to get it reviewed.This patch implies some cleanup in
> concern with bug#62096: Replace compareTo with '=='

This patch breaks the build here:

/home/vmiklos/git/libreoffice/master/svx/source/fmcomp/fmgridif.cxx: In member function ‘long int FmXGridPeer::OnExecuteGridSlot(void*)’:
/home/vmiklos/git/libreoffice/master/svx/source/fmcomp/fmgridif.cxx:2939:88: error: expected primary-expression before ‘||’ token
/home/vmiklos/git/libreoffice/master/svx/source/fmcomp/fmgridif.cxx:2939:100: error: expected ‘;’ before ‘)’ token
make[1]: *** [/home/vmiklos/git/libreoffice/master/workdir/unxlngx6/CxxObject/svx/source/fmcomp/fmgridif.o] Error 1

Please, in the future, at least build-test your patch. For now, I just
fixed it for you, and pushed to master. Also, please use the "[PATCH]"
string in the subject of your mail, or simply push the patch to gerrit:

https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch

that makes it easier for reviewers to notice your patch.

Thanks! :-)

Miklos
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130410/7e78a925/attachment.pgp>


More information about the LibreOffice mailing list