[PATCH] fdo#47018 Impress crashes when modifying bullet

Cao Cuong Ngo (via Code Review) gerrit at gerrit.libreoffice.org
Wed Apr 10 11:51:03 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3312

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/3312/1

fdo#47018 Impress crashes when modifying bullet

Currently the pasting function in Impress does not copy bullet
attribute but uses the default one. The default level depth of bullet
was set to 0 which led to crash. This fix changes the default level
depth to avoid the crash but the real cause why the bullet attribute
isn't copied is still unknown. Anyway it was very dangerous to leave
the default value of 0.

Change-Id: I8a34331006abf3de8c170f8dca43ccf9cec92f04
---
M editeng/source/editeng/eerdll.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/editeng/source/editeng/eerdll.cxx b/editeng/source/editeng/eerdll.cxx
index 59086ea..379a850 100644
--- a/editeng/source/editeng/eerdll.cxx
+++ b/editeng/source/editeng/eerdll.cxx
@@ -98,7 +98,7 @@
         ppDefItems = new SfxPoolItem*[EDITITEMCOUNT];
 
         // Paragraph attributes:
-        SvxNumRule aTmpNumRule( 0, 0, sal_False );
+        SvxNumRule aTmpNumRule( NUM_BULLET_REL_SIZE, 10, sal_False );
 
         ppDefItems[0]  = new SvxFrameDirectionItem( FRMDIR_HORI_LEFT_TOP, EE_PARA_WRITINGDIR );
         ppDefItems[1]  = new SvXMLAttrContainerItem( EE_PARA_XMLATTRIBS );

-- 
To view, visit https://gerrit.libreoffice.org/3312
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a34331006abf3de8c170f8dca43ccf9cec92f04
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Cao Cuong Ngo <cao.cuong.ngo at gmail.com>



More information about the LibreOffice mailing list