[PATCH] Re: Bug 58505 - Tweak F5 for slide display, and add Shift-F5

[Jan Holesovsky]

Hi Kuba,

kuba píše v Út 09. 04. 2013 v 21:16 +0200:

> I've been working on this bug for some time now and It's the high time
> to ask for help.

Terribly sorry that the answer takes us that long :-(

> Since Shift-F5 was taken by replace I changed replace to Shift-mod2-F5
> (Shift-right alt-F5).
> Is this ok? Maybe some other combination would be better?

Changing the already used accelerators is not ideal, unless you actually
do it more conforming to other applications - what do others use for
this (both replace, as well as "start with this slide")?

> Here I decided to use "i" as a key, rather because I didn't know what
> to do so most likely other key would be better.

No problem I guess :-)

> Here (and in /sd/source/ui/inc/OutlineViewShell.hxx) I decided to move
> some code to ShowSlideShow function just like it is in SlotManager
> class (/sd/source/ui/slidesorter/controller/SlsSlotManager.cxx)

Sounds great - glad that you've moved / shared code, instead of copying
& pasting ;-)

> My way of starting presentation from first slide, frankly I don't
> think it's good

Oh I don't see anything bad with that - what exactly do you consider
there as not right?

> Here I took one free value that seemed to be unused.

OK

> Those are all the questions I think, Please criticise and help.

Looks like great work to me - if you clarify the situation with the
accelerator, I think we can push that, unless Thorsten has more ideas of
course :-)

Thank you again for the patch!

All the best,
Kendy