patch for postgresql driver

[Wols Lists]

On 16/04/13 16:13, Lubos Lunak wrote:
> On Tuesday 16 of April 2013, Wols Lists wrote:
>> The attached patch is not in logerrit (I've yet to set that up), and
>> there's an error in it so I'm hoping someone can help. It does a TODO in
>> the file, but I can't get my argument casting right - in the original
>> code, matchIgnoreAsciiCaseAsciiL wraps its argument in
>> RTL_CONSTASCII_STRINGPARAM. This is defined in sal/inc/rtl/string.h and
>> passes both the string and its length. So me removing it is obviously a
>> mistake, but it's got some integrity checking in there and I just can't
>> get it to pass that.
> 
>  Actually removing it is not a mistake. The macro is a cumbersome 
> micro-optimization and here it presumably doesn't make any difference. Just 
> calling matchIgnoreAsciiCase() should do.
> 
>  Also note that LO has SAL_N_ELEMENTS macro for getting the number of items in 
> an array.
> 
Thanks. I'll try those two and see what happens. I'll hunt up that macro
and check it behaves the right way, a good learning curve for me :-)

Cheers,
Wol