[PATCH] Resolves: fdo#63592 changing text direction exits edit mode

Caolán McNamara (via_Code_Review) gerrit at gerrit.libreoffice.org
Thu Apr 18 03:31:17 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3450

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/3450/1

Resolves: fdo#63592 changing text direction exits edit mode

if we're in edit mode, SC_MOD()->InputEnterHandler() kicks
us out of it. But the very similar ScFormatShell::ExecuteAlignment
method doesn't do an InputEnterHandler. I can't see why we
would want to do this, and without it we get the desired
behaviour that tex direction changes and we remain in whatever
mode we were in before changing it

Change-Id: Iaf6e154ffb8f317fda997b302d4075d2efcac8db
---
M sc/source/ui/view/formatsh.cxx
1 file changed, 0 insertions(+), 5 deletions(-)



diff --git a/sc/source/ui/view/formatsh.cxx b/sc/source/ui/view/formatsh.cxx
index c4e7e40..a851893 100644
--- a/sc/source/ui/view/formatsh.cxx
+++ b/sc/source/ui/view/formatsh.cxx
@@ -2056,11 +2056,6 @@
 {
     ScTabViewShell* pTabViewShell = GetViewData()->GetViewShell();
     pTabViewShell->HideListBox();               // Autofilter-DropDown-Listbox
-    if ( GetViewData()->HasEditView( GetViewData()->GetActivePart() ) )
-    {
-        SC_MOD()->InputEnterHandler();
-        pTabViewShell->UpdateInputHandler();
-    }
 
     sal_uInt16 nSlot = rReq.GetSlot();
     switch( nSlot )

-- 
To view, visit https://gerrit.libreoffice.org/3450
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf6e154ffb8f317fda997b302d4075d2efcac8db
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Caolán McNamara <caolanm at redhat.com>



More information about the LibreOffice mailing list