[PATCH]BUG#55846 Comboboxes aren’t displayed when the toolbar is vertical

Eike Rathke erack at redhat.com
Fri Apr 19 12:46:08 PDT 2013


Hi Janit,

On Wednesday, 2013-04-10 00:42:49 +0530, Janit Anjaria wrote:

> I am hereby attaching my bug after making all the needed changes :

I fail to see where this patch actually changes code (except two cases)
and not just spacing or ordering of variables. If it was meant as an
additional patch on top of the previous patch in this thread that was
not pushed, please don't do that. Combine both changes into one using
git commit --amend  (if both patches are the last two commits) or
git rebase -i ...  (to squash (and reorder if necessary) if they are not
on top)

>              long  nWinWidth = mnDX - nLeft - nRight;
>              if( nWinWidth > nLineSize )
> -                nLineSize =  mnMaxItemWidth;
> +		nLineSize =  nWinWidth;

This new indentation doesn't look right.


  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
For key transition see http://erack.de/key-transition-2013-01-10.txt.asc
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130419/e122154e/attachment.pgp>


More information about the LibreOffice mailing list