[PATCH] Slightly simplify loop

[Matteo Casalin (via Code Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3539

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/3539/1

Slightly simplify loop

Change-Id: If44e86ceecd4a407d3b4e294a03a84ad010f95e1
---
M editeng/source/misc/hangulhanja.cxx
1 file changed, 3 insertions(+), 5 deletions(-)



diff --git a/editeng/source/misc/hangulhanja.cxx b/editeng/source/misc/hangulhanja.cxx
index 4f7189a..7d2c01e 100644
--- a/editeng/source/misc/hangulhanja.cxx
+++ b/editeng/source/misc/hangulhanja.cxx
@@ -534,9 +534,7 @@
 
     bool HangulHanjaConversion_Impl::ContinueConversion( bool _bRepeatCurrentUnit )
     {
-        bool bNeedUserInteraction = false;  // when we leave here, do we need user interaction?
-
-        while ( !bNeedUserInteraction && implNextConvertible( _bRepeatCurrentUnit ) )
+        while ( implNextConvertible( _bRepeatCurrentUnit ) )
         {
             OUString sCurrentUnit( GetCurrentUnit() );
 
@@ -576,11 +574,11 @@
 
                 // do not look for the next convertible: We have to wait for the user to interactivly
                 // decide what happens with the current convertible
-                bNeedUserInteraction = true;
+                return false;
             }
         }
 
-        return !bNeedUserInteraction;
+        return true;
     }
 
     bool HangulHanjaConversion_Impl::implGetConversionDirectionForCurrentPortion( HHC::ConversionDirection& rDirection )

-- 
To view, visit https://gerrit.libreoffice.org/3539
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If44e86ceecd4a407d3b4e294a03a84ad010f95e1
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matteo Casalin <matteo.casalin at gmx.com>