[PATCH] Do not store return value for later, just exit

Matteo Casalin (via Code Review) gerrit at gerrit.libreoffice.org
Sun Apr 21 09:42:03 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3541

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/3541/1

Do not store return value for later, just exit

Change-Id: If71398ee5a29652303ae492d23e3910526307d3c
---
M editeng/source/editeng/textconv.cxx
1 file changed, 3 insertions(+), 4 deletions(-)



diff --git a/editeng/source/editeng/textconv.cxx b/editeng/source/editeng/textconv.cxx
index e309441..b9324c5 100644
--- a/editeng/source/editeng/textconv.cxx
+++ b/editeng/source/editeng/textconv.cxx
@@ -96,8 +96,6 @@
 
     }
 
-    bool bGoOn = false;
-
     if ( m_bStartDone && m_bEndDone )
     {
         if ( ConvMore_impl() )  // examine another document?
@@ -112,9 +110,10 @@
     {
         m_bStartChk = !m_bStartDone;
         ConvStart_impl( m_bStartChk ? SVX_SPELL_BODY_START : SVX_SPELL_BODY_END );
-        bGoOn = true;
+        return true;
     }
-    return bGoOn;
+
+    return false;
 }
 
 

-- 
To view, visit https://gerrit.libreoffice.org/3541
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If71398ee5a29652303ae492d23e3910526307d3c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matteo Casalin <matteo.casalin at gmx.com>



More information about the LibreOffice mailing list