[PATCH libreoffice-4-0] fdo#330191 a NULL value of float type is not NaN

[Lionel Elie Mamane (via Code Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3599

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/3599/1

fdo#330191 a NULL value of float type is not NaN

but it is *still* NULL.

This was initially done to "fix" i#108092,
but i#112652 comment 13 suggests this may have been fixed more cleanly.

Change-Id: I2b76af2182715bc489cb89dd45d6b77d5038b506
---
M reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/TableCellLayoutController.java
1 file changed, 0 insertions(+), 5 deletions(-)



diff --git a/reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/TableCellLayoutController.java b/reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/TableCellLayoutController.java
index 1489098..9f0340a 100644
--- a/reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/TableCellLayoutController.java
+++ b/reportbuilder/java/com/sun/star/report/pentaho/layoutprocessor/TableCellLayoutController.java
@@ -73,11 +73,6 @@
             {
                 FormatValueUtility.applyValueForCell(value.getValue(), attributeMap, valueType);
             }
-            else if ( "float".equals(valueType))
-            {
-                attributeMap.setAttribute(OfficeNamespaces.OFFICE_NS,
-                    FormatValueUtility.VALUE, "NaN");
-            }
             // #i114108#: except on form elements, the only value-type that can
             // occur without an accomanying value attribute is "string"
             else if (!"string".equals(valueType))

-- 
To view, visit https://gerrit.libreoffice.org/3599
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b76af2182715bc489cb89dd45d6b77d5038b506
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Lionel Elie Mamane <lionel at mamane.lu>