[Patch] Bug 47302-Adding a new field in "Insert->Fields"

Thorsten Behrens thb at documentfoundation.org
Wed Apr 24 11:01:21 PDT 2013


Vishv Brahmbhatt wrote:
> I am hereby attaching my patch for review.
> 
Hi Vishv,

wow, impressive work - compiles & works mostly fine here!!

Two things - there's a lot of whitespace change in your patch, and
also some trailing whitespace on some lines (the git commit hooks
complain about it) - could you clean that up?

And then, loading and saving this new field does not yet work. I think
the relevant code lives here:

 xmloff/source/text/txtfld{ei}.cxx

The scripting/workben/bindings/impressmenubar.xml change, you can just
skip, that seems example code.

As an extra, it seems changing the slide name does not update the
field content, possibly some
Broadcast(SfxSimpleHint(SFX_HINT_DATACHANGED)) or somesuch missing at
a strategic place? Of course, happy to merge w/o, and/or help with
tracking that nit down. :)

> Also there is new file created
> @offapi/com/sun/star/text/textfield/SlideName.idl for the patch. So I am
> attaching that file too.
> 
You can just git add offapi/com/sun/star/text/textfield/SlideName.idl
it, will then be included in your subsequent commit.

Cheers,

-- Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130424/bc6e8185/attachment.pgp>


More information about the LibreOffice mailing list