[PATCH] c:delete is true by default in Excel

Markus Mohrhard (via Code Review) gerrit at gerrit.libreoffice.org
Mon Apr 29 09:19:11 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3684

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/3684/1

c:delete is true by default in Excel

One step closer to opening my simple test file correctly in Excel.

Change-Id: I1bfa76a46081ba478e44d8d90d8a91790a9a9ff3
(cherry picked from commit 6ddd7fccdc8fc292200e581dbc4e456ec86cef47)
---
M oox/source/export/chartexport.cxx
1 file changed, 2 insertions(+), 6 deletions(-)



diff --git a/oox/source/export/chartexport.cxx b/oox/source/export/chartexport.cxx
index 745b953..9cb85db 100644
--- a/oox/source/export/chartexport.cxx
+++ b/oox/source/export/chartexport.cxx
@@ -2088,13 +2088,9 @@
             OUString ("Visible")) >>=  bVisible;
     }
 
-    if( !bVisible )
-    {
-        // other value?
-        pFS->singleElement( FSNS( XML_c, XML_delete ),
-            XML_val, "1",
+    pFS->singleElement( FSNS( XML_c, XML_delete ),
+            XML_val, bVisible ? "0" : "1",
             FSEND );
-    }
 
     // FIXME: axPos, need to check the property "ReverseDirection"
     pFS->singleElement( FSNS( XML_c, XML_axPos ),

-- 
To view, visit https://gerrit.libreoffice.org/3684
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bfa76a46081ba478e44d8d90d8a91790a9a9ff3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Markus Mohrhard <markus.mohrhard at googlemail.com>



More information about the LibreOffice mailing list