New bug, looking for source location for setting Calc formulas

[Eike Rathke]

Hi Andrew,

On Friday, 2013-08-30 01:27:05 -0400, Andrew Douglas Pitonyak wrote:

> On 08/29/2013 10:44 PM, Andrew Douglas Pitonyak wrote:
> >Setting the Formula property on a Calc cell has always expected
> >English formulas. Use the FormulaLocal property otherwise. The new
> >behavior is that the Formula property acts the same as
> >FormulaLocal

Plus .Formula is influenced by the current work locale (not UI
language), which it should not.

> >https://bugs.freedesktop.org/show_bug.cgi?id=67836

I'll take a look.

> >I became aware of this based on a post on the mailing list. Turns
> >out there was already an open and not verified bug. I have
> >verified the behavior but would like to chat with the responsible
> >developer before changing to confirmed and asking the responsible
> >party to consider backing out their change (as well as can be done
> >after a release).

Better fix it..

Finding the range of commits btw that introduced a change in behavior
can be done with bibisect, see
https://wiki.documentfoundation.org/Bibisect

> >Alternatively, I can at least document the new
> >behavior that the two properties are identical so you might as
> >well deprecate one.

No, it's a bug.

> Looks like setting the FormulaLocal property is probably handled in
> sc/source/ui/unoobj/cellsuno.cxx
> ScCellObj::SetOnePropertyValue
> this calls SetString_Impl

With (should be) bEnglish=true for .Formula and bEnglish=false for
.FormulaLocal

> My head hurts now.

Understandably ;-)

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
For key transition see http://erack.de/key-transition-2013-01-10.txt.asc
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130830/fd943f90/attachment.pgp>