broken backwards compatibility with certain old charts
Lionel Elie Mamane
lionel at mamane.lu
Sat Aug 31 01:44:49 PDT 2013
I'd like to draw your attention on my commit
Author: Lionel Elie Mamane <lionel at mamane.lu>
Date: Fri Aug 30 18:00:21 2013 +0200
fdo#68663 don't blindly force categories when there are none
If the comment is right (which is not always the case in the
LibreOffice codebase...), then I've just broken reading of categories
for these kinds of old "files with own data without a categories
element but with row descriptions".
This code was pretty much unconditionally always adding categories,
although I could see no trace of "row description" in the charts
generated by Report Builder; by force-adding categories, this was
leading to fdo#68663.
So, if anyone has a clue how to make that "force-add categories"
conditional to the presence of these mysterious "row descriptions",
I'd be happy to collaborate to add this (now properly conditional)
"add categories" back.
We would also need to revert the subsequent -Werror cleanup
Author: Julien Nabet <serval2412 at yahoo.fr>
Date: Fri Aug 30 21:02:26 2013 +0200
-Werror=unused-but-set-variable second try
I also don't quite understand why the removed code was not passing
"&rLSequencesPerIndex" as 6th argument. Shouldn't it have?
More information about the LibreOffice