[PATCH] HiDPI fixes for squiggly underlines

Jan Holesovsky kendy at collabora.com
Fri Dec 13 06:54:38 PST 2013


Hi Keith,

Keith Curtis píše v Po 09. 12. 2013 v 19:36 -0500:

> LibreOffice looks good on a HiDPI screens but there are a few small
> bugs such as (fdo#51735)
> 
> So I'm working on fixing the squiggly underlines. Patch included below.

First of all, thank you so much for the patches you have submitted so
far!

I looked at them, and what I think fits best at the moment is a kind of
float mfHidpiRatio (or so) set on the startup that will tell internally
how much should we scale the various UI elements in order to look
correctly on the given device.

With that, we should be able to touch as low level parts as possible to
get the effect that is desirable; I'd hope that for example for the
squiggly lines, we would be able to modify ImplDrawWaveLine() directly
so that all the callers immediately get the waves that fit the hidpi
screen nicely.

Unfortunately I cannot do much on this / integrate your patches this
week yet [4.2 UI freeze on Monday ;-)], but I'll do that early next week
- I hope that is OK for you?

All the best,
Kendy



More information about the LibreOffice mailing list