cppcheck: Duplicate branch if/else in op_statistical.cxx (sc/../opencl)

julien2412 serval2412 at yahoo.fr
Sat Dec 14 14:24:17 PST 2013


Hello,

Cppcheck reported this:
[sc/source/core/opencl/op_statistical.cxx:5103] ->
[sc/source/core/opencl/op_statistical.cxx:5099]: (style) Found duplicate
branches for 'if' and 'else'

Indeed, we have:
   5095             if (!pCurDVR->IsStartFixed() && pCurDVR->IsEndFixed())
   5096             {
   5097                 ss << "gid0; endFlag = "<< nCurWindowSize
<<"-gid0;\n";
   5098             }
   5099             else if (pCurDVR->IsStartFixed() &&
!pCurDVR->IsEndFixed())
   5100             {
   5101                 ss << "gid0; endFlag = gid0+"<< nCurWindowSize
<<";\n";
   5102             }
   5103             else
   5104             {
   5105                 ss << "gid0; endFlag = gid0+"<< nCurWindowSize
<<";\n";
   5106             }

See
http://opengrok.libreoffice.org/xref/core/sc/source/core/opencl/op_statistical.cxx#5095

Any idea what should it be?

Julien



--
View this message in context: http://nabble.documentfoundation.org/cppcheck-Duplicate-branch-if-else-in-op-statistical-cxx-sc-opencl-tp4088219.html
Sent from the Dev mailing list archive at Nabble.com.


More information about the LibreOffice mailing list