Cppcheck: ''bSkipBreaks' is assigned a value that is never used (sc)
Caolán McNamara
caolanm at redhat.com
Tue Feb 5 15:03:31 PST 2013
On Tue, 2013-02-05 at 14:26 -0800, julien2412 wrote:
> Hello,
>
> Cppcheck detected this:
> sc/source/core/data/table5.cxx
> 147 unreadVariable style Variable 'bSkipBreaks' is assigned a value that is
> never used.
Hmm, I reckon kohei should have a look at that. bSkipBreaks doesn't go
anywhere so its doing nothing. git blame shows d8c68b41b and references
#i94698 and looking at the context of the original patch there it seems
that back then there was only a single "bSkipBreaks" bool while now
there are two, bSkipColBreaks and bSkipRowBreaks.
Presumably somewhere along the go-ooo time
sc-fit-to-width-height-skip-breaks.diff didn't apply after bSkipBreaks
got split into bSkipColBreaks and bSkipRowBreaks and the fixup didn't
take account of that.
C.
More information about the LibreOffice
mailing list