[PATCH] cppCheck: Variable is reassigned a value before the old one ...

Christophe JAILLET (via Code Review) gerrit at gerrit.libreoffice.org
Wed Feb 6 02:16:14 PST 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2014

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/2014/1

cppCheck: Variable is reassigned a value before the old one has been used.

Change-Id: I42cfb06dd8b6b0ff7d4fec6e3b296fa61302c1c0
Signed-off-by: jailletc36 <christophe.jaillet at wanadoo.fr>
---
M extensions/source/plugin/win/winmgr.cxx
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/extensions/source/plugin/win/winmgr.cxx b/extensions/source/plugin/win/winmgr.cxx
index 17f06d3..4f62ecd 100644
--- a/extensions/source/plugin/win/winmgr.cxx
+++ b/extensions/source/plugin/win/winmgr.cxx
@@ -160,7 +160,7 @@
 static void add_NS_keys( HKEY hKey, PluginLocationMap & rPlugins )
 {
     TCHAR value[MAX_PATH];
-    DWORD dwType, size = sizeof(value);
+    DWORD dwType, size;
 
     // 4.7
     size = sizeof(value);
@@ -219,7 +219,7 @@
 static void add_MozPlugin( HKEY hKey, PluginLocationMap & rPlugins )
 {
     TCHAR value[MAX_PATH];
-    DWORD dwType, size = sizeof(value);
+    DWORD dwType, size;
 
     size = sizeof(value);
     if (::RegQueryValueEx(

-- 
To view, visit https://gerrit.libreoffice.org/2014
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I42cfb06dd8b6b0ff7d4fec6e3b296fa61302c1c0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Christophe JAILLET <christophe.jaillet at wanadoo.fr>


More information about the LibreOffice mailing list