[PATCH] Remove useless function calls.

Christophe JAILLET (via Code Review) gerrit at gerrit.libreoffice.org
Wed Feb 6 03:27:14 PST 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2015

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/2015/1

Remove useless function calls.

nPos has already been computed the 3 lines above. No need to recompute it.

Change-Id: Iad739d6fffd2c40cc633789edfe88d13e87dd28b
Signed-off-by: jailletc36 <christophe.jaillet at wanadoo.fr>
---
M sc/source/ui/optdlg/opredlin.cxx
1 file changed, 0 insertions(+), 4 deletions(-)



diff --git a/sc/source/ui/optdlg/opredlin.cxx b/sc/source/ui/optdlg/opredlin.cxx
index 6badae1..cf4b486 100644
--- a/sc/source/ui/optdlg/opredlin.cxx
+++ b/sc/source/ui/optdlg/opredlin.cxx
@@ -89,7 +89,6 @@
     nPos = aContentColorLB.GetSelectEntryPos();
     if (nPos != LISTBOX_ENTRY_NOTFOUND)
     {
-        nPos = aContentColorLB.GetSelectEntryPos();
         if (nPos!=0)
             nNew= aContentColorLB.GetEntryColor(nPos).GetColor();
         else
@@ -101,7 +100,6 @@
     nPos = aMoveColorLB.GetSelectEntryPos();
     if (nPos != LISTBOX_ENTRY_NOTFOUND)
     {
-        nPos = aMoveColorLB.GetSelectEntryPos();
         if (nPos!=0)
             nNew= aMoveColorLB.GetEntryColor(nPos).GetColor();
         else
@@ -113,7 +111,6 @@
     nPos = aInsertColorLB.GetSelectEntryPos();
     if (nPos != LISTBOX_ENTRY_NOTFOUND)
     {
-        nPos = aInsertColorLB.GetSelectEntryPos();
         if (nPos!=0)
             nNew= aInsertColorLB.GetEntryColor(nPos).GetColor();
         else
@@ -125,7 +122,6 @@
     nPos = aRemoveColorLB.GetSelectEntryPos();
     if (nPos != LISTBOX_ENTRY_NOTFOUND)
     {
-        nPos = aRemoveColorLB.GetSelectEntryPos();
         if (nPos!=0)
             nNew= aRemoveColorLB.GetEntryColor(nPos).GetColor();
         else

-- 
To view, visit https://gerrit.libreoffice.org/2015
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad739d6fffd2c40cc633789edfe88d13e87dd28b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Christophe JAILLET <christophe.jaillet at wanadoo.fr>


More information about the LibreOffice mailing list