[PATCH] fdo#39370 - Fixed RTL/LTR and alignment buttons location on ...

Issa Alkurtass (via Code Review) gerrit at gerrit.libreoffice.org
Sat Feb 9 22:53:33 PST 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2077

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/2077/1

fdo#39370 - Fixed RTL/LTR and alignment buttons location on RTL interface

Reversed the location of the RTL and LTR buttons as well as the align right
and align left buttons on the RTL interface. It now matches the LTR interface.
Done from toolboxdocumenthandler instead of modifying 20+ xml files.

Change-Id: I6b3715e134bb45a7500b87a9e926d7940690a9af
---
M framework/source/fwe/xml/toolboxdocumenthandler.cxx
1 file changed, 17 insertions(+), 0 deletions(-)



diff --git a/framework/source/fwe/xml/toolboxdocumenthandler.cxx b/framework/source/fwe/xml/toolboxdocumenthandler.cxx
index b57d158..7826ac2 100644
--- a/framework/source/fwe/xml/toolboxdocumenthandler.cxx
+++ b/framework/source/fwe/xml/toolboxdocumenthandler.cxx
@@ -423,6 +423,23 @@
                     aToolbarItemProp[5].Name = m_aIsVisible;
                     aToolbarItemProp[6].Name = m_aTooltip;
 
+                    //fix for fdo#39370
+                    /// check whether RTL interface or not
+                    if(Application::GetSettings().GetLayoutRTL()){
+                        if (aCommandURL.compareTo(".uno:ParaLeftToRight") == 0)
+                            aCommandURL = ".uno:ParaRightToLeft";
+                        else if (aCommandURL.compareTo(".uno:ParaRightToLeft") == 0)
+                            aCommandURL = ".uno:ParaLeftToRight";
+                        else if (aCommandURL.compareTo(".uno:LeftPara") == 0)
+                            aCommandURL = ".uno:RightPara";
+                        else if (aCommandURL.compareTo(".uno:RightPara") == 0)
+                            aCommandURL = ".uno:LeftPara";
+                        else if (aCommandURL.compareTo(".uno:AlignLeft") == 0)
+                            aCommandURL = ".uno:AlignRight";
+                        else if (aCommandURL.compareTo(".uno:AlignRight") == 0)
+                            aCommandURL = ".uno:AlignLeft";
+                    }
+
                     aToolbarItemProp[0].Value <<= aCommandURL;
                     aToolbarItemProp[1].Value <<= aHelpURL;
                     aToolbarItemProp[2].Value <<= aLabel;

-- 
To view, visit https://gerrit.libreoffice.org/2077
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b3715e134bb45a7500b87a9e926d7940690a9af
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Issa Alkurtass <ialkurtass at kacst.edu.sa>


More information about the LibreOffice mailing list