[PATCH libreoffice-4-0] resorted SvTreeLists munged horribly

Caolán McNamara (via_Code_Review) gerrit at gerrit.libreoffice.org
Sun Feb 10 13:38:58 PST 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2093

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/93/2093/1

resorted SvTreeLists munged horribly

e.g. tools->options->paths, click the sort icon, reclick it few
times and the list doesn't reverse but instead shows the
same two entries over and over again.

Regression since fb01d8e132ab9097ed30b3bc4c7585622df591ad

Change-Id: Ifc151ad72a27f1cdc3141e356ad6d100e6219cc2
(cherry picked from commit dde8e266084c89860a9a91f2a29ac31b730a9c4a)
---
M svtools/source/contnr/treelist.cxx
1 file changed, 1 insertion(+), 0 deletions(-)



diff --git a/svtools/source/contnr/treelist.cxx b/svtools/source/contnr/treelist.cxx
index d0125f4..43968c5 100644
--- a/svtools/source/contnr/treelist.cxx
+++ b/svtools/source/contnr/treelist.cxx
@@ -1583,6 +1583,7 @@
             // Recursively sort child entries.
             ResortChildren(p);
     }
+    SetListPositions(pParent->maChildren); // correct list position in target list
 }
 
 void SvTreeList::GetInsertionPos( SvTreeListEntry* pEntry, SvTreeListEntry* pParent,

-- 
To view, visit https://gerrit.libreoffice.org/2093
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc151ad72a27f1cdc3141e356ad6d100e6219cc2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Caolán McNamara <caolanm at redhat.com>


More information about the LibreOffice mailing list