patch removing Labels.xcu out of configuration

Michael Meeks michael.meeks at suse.com
Wed Feb 13 13:05:12 PST 2013


Hi Matus,

On Wed, 2013-02-13 at 21:04 +0100, Matúš Kukan wrote:
> I've finished my first patch on reducing configuration data and
> decided to send it this way.

	It looks lovely ! :-) thanks for that.

> It seems to work, although not as I was expecting.
> You still can't save modified labels, not sure why, but that's nothing new.
> Please, feel free to comment anything.

	I've got a few cleanups here to misc. warnings etc. and I'm doing a
from-clean build - I hope to push tomorrow morning.

	Have you tested that it's still possible to add a manufacturer in the
configuration ? [ the code looks fine but always worth a check ;-].

	Wrt. the saving issue - it'd be interesting to see what happens in
SwLabelConfig::SaveLabel as you step through that when clicking 'Ok' in
the relevant dialog. Are we failing to add the node ? are we somehow not
committing it or something ?

	Anyhow - great work,

	Thanks,

		Michael.

-- 
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot



More information about the LibreOffice mailing list