useless definition of _SV_RULER_CXX ?

Miklos Vajna vmiklos at suse.cz
Fri Feb 15 02:05:37 PST 2013


On Thu, Feb 14, 2013 at 02:43:16PM +0000, Caolán McNamara <caolanm at redhat.com> wrote:
> My best theory is that it was intended to speed up builds by having less
> "stuff" in the headers for compilers to parse by having the preprocessor
> strip out the stuff includers didn't need to see. Which would suggest
> that it will only be found around private methods, i.e. not
> protected/public methods or anything that takes up space.

I think they tried to avoid including headers for enumerations this way
-- given that in C++ it's not possible to declare enumerations as an
incomplete type, AFAIK.

> So, IMO it's not necessary and feel free to remove it.

Agreed, better to remove these, those -- usually small -- headers
containing the enumerations should not really make the build longer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130215/1879016c/attachment.pgp>


More information about the LibreOffice mailing list