[PATCH] Remove not needed function in calc

Marcos Souza (via Code Review) gerrit at gerrit.libreoffice.org
Sat Feb 16 09:22:16 PST 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/2187

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/2187/1

Remove not needed function in calc

Change-Id: I0be7d751a52d11687c15042023b7a6ebb0122c64
---
M sc/source/ui/collab/sendfunc.hxx
1 file changed, 7 insertions(+), 15 deletions(-)



diff --git a/sc/source/ui/collab/sendfunc.hxx b/sc/source/ui/collab/sendfunc.hxx
index f7fcca9..6bd9a1e 100644
--- a/sc/source/ui/collab/sendfunc.hxx
+++ b/sc/source/ui/collab/sendfunc.hxx
@@ -34,17 +34,12 @@
 // method name ';' then arguments ; separated
 class ScChangeOpWriter
 {
-    rtl::OUStringBuffer aMessage;
-    void appendSeparator()
-    {
-        aMessage.append( sal_Unicode( ';' ) );
-    }
+    OUStringBuffer aMessage;
 
 public:
     ScChangeOpWriter( const char *pName )
     {
-        aMessage.appendAscii( pName );
-        appendSeparator();
+        aMessage.append( OUString(pName ) + ";");
     }
 
     void appendString( const rtl::OUString &rStr )
@@ -58,27 +53,24 @@
         }
         else
             aMessage.append( rStr );
-        appendSeparator();
+        aMessage.append(";");
     }
 
     void appendAddress( const ScAddress &rPos )
     {
-        rtl::OUString aStr;
+        OUString aStr;
         rPos.Format( aStr, SCA_VALID );
-        aMessage.append( aStr );
-        appendSeparator();
+        aMessage.append( aStr + ";" );
     }
 
     void appendInt( sal_Int32 i )
     {
-        aMessage.append( i );
-        appendSeparator();
+        aMessage.append( OUString::number(i) + ";" );
     }
 
     void appendBool( sal_Bool b )
     {
-        aMessage.appendAscii( b ? "true" : "false" );
-        appendSeparator();
+        aMessage.append( OUString(b ? "true" : "false" ) + ";";
     }
 
     void appendCell( ScBaseCell *pCell )

-- 
To view, visit https://gerrit.libreoffice.org/2187
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0be7d751a52d11687c15042023b7a6ebb0122c64
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza <marcos.souza.org at gmail.com>


More information about the LibreOffice mailing list