Cppcheck: 'is_vertical_run' is assigned a value that is never used (vcl module)

[Jan Holesovsky]

Hi Julien,

julien2412 píše v Pá 15. 02. 2013 v 15:13 -0800:

> Cppcheck reported this:
> vcl/coretext/salcoretextlayout.cxx
> 569	unreadVariable	style	Variable 'is_vertical_run' is assigned a value that
> is never used.
> 
>     565                     bool is_vertical_run = false;
>     566                     CFDictionaryRef aDict = CTRunGetAttributes( run
> );
>     567                     if ( aDict ) {
>     568                         const CFBooleanRef aValue = (const
> CFBooleanRef)CFDictionaryGetValue( aDict, kCTVerticalFormsAttributeName );
>     569                         is_vertical_run =  (aValue ==
> kCFBooleanTrue) ? true : false;
>     570                     }
> 
> See
> http://opengrok.libreoffice.org/xref/core/vcl/coretext/salcoretextlayout.cxx#565
> 
> Should "vertical_run" variable just be removed or should it be used in a
> way?

 From what I see, it has been introduced with

http://cgit.freedesktop.org/libreoffice/core/commit/?id=83ba7b4e8f67cc3a21fbaf476621af509032ae47

Tor - can it go, or is it of some use for later?

Regards,
Kendy