Question cppcheck reports on svx/source/svdraw/svdoedge.cxx (Bezier curve)

Caolán McNamara caolanm at redhat.com
Tue Feb 26 15:20:01 PST 2013


On Wed, 2012-12-19 at 15:00 -0800, julien2412 wrote:
> Hello,
> 
> Cppcheck detected this into svx/source/svdraw/svdoedge.cxx
> [svdoedge.cxx:1450]: (style) Variable 'pPt1' is assigned a value that is
> never used.
> [svdoedge.cxx:1453]: (style) Variable 'pPt4' is assigned a value that is
> never used

That SdrEdgeObj::ImpCalcEdgeTrack is one of the most unpleasantly long
and unreadable things I've seen in LibreOffice.

> Either pPt1 and pPt4 assignations may really be removed or a change must be
> done here.

git blame && show on results indicate it's there since initial
OOo-ification in 2000. It looks like a dead loss to me to do anything
except remove the assignations that have no utility.

C.



More information about the LibreOffice mailing list